fix scope for defineOwnProperties #1226
Conversation
| * @param o | ||
| * @param level | ||
| * @return boolean | ||
| * @see <a | ||
| * href="https://262.ecma-international.org/11.0/#sec-testintegritylevel">TestIntegrityLevel</a> | ||
| */ | ||
| static boolean testIntegrityLevel(Context cx, Object o, INTEGRITY_LEVEL level) { | ||
| static boolean testIntegrityLevel( |
There was a problem hiding this comment.
Mmm, the idea of all the methods in this class is that they implement the abstract object operations as defined by EcmaScript (with the addition of Context as first param): testIntegretyLevel in the EcmaScript specification doesn't have a scope parameter
There was a problem hiding this comment.
From my point of view scope is like context, we need to add this to the params of many methods.
There was a problem hiding this comment.
I think the (top level) scope should be derivable from the ScriptableObject.
I think the issue here is that the prototype of the function is a NativeObject instance on which the parentScope isn;t set accordingly, hence it ends up being null in the ScriptableObject.getOwnPropertyDescriptor(...) method.
Adding obj.setParentScope(this); after the construction of the NativeObject instance in BaseFunction.setupDefaultPrototype() solves that. Then in ScriptableObject.getOwnPropertyDescriptor(...) the getParentSCope call starts working properly, by always returning a proper scope and the problem guess away
Did a quick test with this approach and it seems to solve the problem
There was a problem hiding this comment.
Sounds reasonable, will have a look and maybe prepare another PR,
No description provided.